feat: mark selected public enums as #[non_exhaustive] #1040
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s#1016) - lambda-events (dynamodb): StreamViewType, StreamStatus, SharedIteratorType, OperationType, KeyType - lambda-http: PayloadError, JsonPayloadError, FormUrlEncodedPayloadError These enums are likely to grow; marking them non_exhaustive helps avoid semver hazards for downstream consumers who pattern-match exhaustively.
|
Hi, looks good to me! |
|
@PartiallyUntyped Sounds good, if anything needs tweaked just let me know! |
|
@PartiallyUntyped CI is red, nightly rustdoc now rejects socket2’s doc_auto_cfg, and cargo-semver-checks marks the new #[non_exhaustive] enums as a breaking change. Should I drop the non-exhaustive annotations for the existing enums, or are there plans for a major release / pinning rustdoc to handle this? |
PartiallyUntyped
approved these changes
Oct 8, 2025
|
We will do a semver update down the road once we've updated all events. Thanks a lot for your contribution! ^_^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partially addresses #1016 by marking a small set of public enums as so that downstream exhaustive matches remain forward-compatible as event shapes evolve.
Changes
These types are likely to gain additional variants over time. Making them non-exhaustive reduces semver churn at the cost of requiring a wildcard match in consumers.
This is intentionally a minimal first step to validate appetite and direction; happy to expand the scope across crates in follow-ups or adjust the target set.